HuaHuaY commented on code in PR #49082:
URL: https://github.com/apache/arrow/pull/49082#discussion_r2749235190
##########
cpp/src/parquet/arrow/variant_internal.h:
##########
@@ -50,7 +50,7 @@ class PARQUET_EXPORT VariantExtensionType : public
::arrow::ExtensionType {
public:
explicit VariantExtensionType(const std::shared_ptr<::arrow::DataType>&
storage_type);
- std::string extension_name() const override { return "parquet.variant"; }
+ std::string extension_name() const override { return
"arrow.parquet.variant"; }
Review Comment:
JsonExtensionType also uses hardcoded extension name. If we want to define
string literals, I suggest to move other's extension types' names into a same
file.
##########
cpp/src/parquet/arrow/variant_internal.h:
##########
@@ -50,7 +50,7 @@ class PARQUET_EXPORT VariantExtensionType : public
::arrow::ExtensionType {
public:
explicit VariantExtensionType(const std::shared_ptr<::arrow::DataType>&
storage_type);
- std::string extension_name() const override { return "parquet.variant"; }
+ std::string extension_name() const override { return
"arrow.parquet.variant"; }
Review Comment:
`JsonExtensionType` also uses hardcoded extension name. If we want to define
string literals, I suggest to move other's extension types' names into a same
file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
