HuaHuaY commented on code in PR #49082:
URL: https://github.com/apache/arrow/pull/49082#discussion_r2749238081
##########
cpp/src/parquet/arrow/variant_internal.h:
##########
@@ -50,7 +50,7 @@ class PARQUET_EXPORT VariantExtensionType : public
::arrow::ExtensionType {
public:
explicit VariantExtensionType(const std::shared_ptr<::arrow::DataType>&
storage_type);
- std::string extension_name() const override { return "parquet.variant"; }
+ std::string extension_name() const override { return
"arrow.parquet.variant"; }
Review Comment:
Do we need to move `variant_internal.h` to `cpp/src/arrow/extension/` like
other extension types.
##########
cpp/src/parquet/arrow/variant_internal.h:
##########
@@ -50,7 +50,7 @@ class PARQUET_EXPORT VariantExtensionType : public
::arrow::ExtensionType {
public:
explicit VariantExtensionType(const std::shared_ptr<::arrow::DataType>&
storage_type);
- std::string extension_name() const override { return "parquet.variant"; }
+ std::string extension_name() const override { return
"arrow.parquet.variant"; }
Review Comment:
Do we need to move `variant_internal.h` to `cpp/src/arrow/extension/` like
other extension types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
