codephage2020 commented on code in PR #9346: URL: https://github.com/apache/arrow-rs/pull/9346#discussion_r2758915708
########## arrow-string/src/length.rs: ########## @@ -50,7 +50,7 @@ fn bit_length_impl<P: ArrowPrimitiveType>( /// For string array and binary array, length is the number of bytes of each value. /// /// * this only accepts ListArray/LargeListArray, StringArray/LargeStringArray/StringViewArray, BinaryArray/LargeBinaryArray, and FixedSizeListArray, -/// or DictionaryArray with above Arrays as values +/// ListViewArray/LargeListViewArray, or DictionaryArray with above Arrays as values Review Comment: ```suggestion /// and ListViewArray/LargeListViewArray, or DictionaryArray with above Arrays as values ``` ########## arrow-string/src/length.rs: ########## @@ -50,7 +50,7 @@ fn bit_length_impl<P: ArrowPrimitiveType>( /// For string array and binary array, length is the number of bytes of each value. /// /// * this only accepts ListArray/LargeListArray, StringArray/LargeStringArray/StringViewArray, BinaryArray/LargeBinaryArray, and FixedSizeListArray, Review Comment: ```suggestion /// * this only accepts ListArray/LargeListArray, StringArray/LargeStringArray/StringViewArray, BinaryArray/LargeBinaryArray, FixedSizeListArray, ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
