codephage2020 commented on PR #9346: URL: https://github.com/apache/arrow-rs/pull/9346#issuecomment-3844700165
> Actually, I don't think it makes sense to support list types in `bit_length` 🤔 > I know we have existing support for regular List/LargeList, but this seems to be introduced in error by #4718 as far as I can tell. It doesn't make sense to compute bit length of lists based on the assumption that each element of the list = 1 byte. @Jefffrey Exactly. After reviewing the code, `bit_length` for List/LargeList multiplies element count by 8, which is semantically wrong since elements can be arbitrary types. > Oh I see. Thanks. I'll remove it then. @vegarsti Could you also remove the existing List/LargeList support for `bit_length`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
