codephage2020 commented on code in PR #9347:
URL: https://github.com/apache/arrow-rs/pull/9347#discussion_r2759280722
##########
arrow-ord/src/comparison.rs:
##########
@@ -109,14 +109,95 @@ where
Ok(BooleanArray::new(values, None))
}
+/// Checks if a [`GenericListViewArray`] contains a value in the
[`PrimitiveArray`]
+pub fn in_list_view<T, OffsetSize>(
+ left: &PrimitiveArray<T>,
+ right: &GenericListViewArray<OffsetSize>,
+) -> Result<BooleanArray, ArrowError>
+where
+ T: ArrowNumericType,
+ OffsetSize: OffsetSizeTrait,
+{
+ let left_len = left.len();
+ if left_len != right.len() {
+ return Err(ArrowError::ComputeError(
+ "Cannot perform comparison operation on arrays of different
length".to_string(),
+ ));
+ }
+
+ let num_bytes = bit_util::ceil(left_len, 8);
Review Comment:
> Sorry - yes, I mean line 128. But I think I misread! I was thinking this
was doing the max of the left length and 8, but it's not, it's
>
> ```
> /// Returns the ceil of `value`/`divisor`
> ```
It's okay, thank you for your review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
