Jefffrey commented on code in PR #9347:
URL: https://github.com/apache/arrow-rs/pull/9347#discussion_r2761736979
##########
arrow-ord/src/comparison.rs:
##########
@@ -109,14 +109,96 @@ where
Ok(BooleanArray::new(values, None))
}
+/// Checks if each value in the [`PrimitiveArray`] is contained in the
corresponding [`GenericListViewArray`] element
+pub fn in_list_view<T, OffsetSize>(
Review Comment:
Personally I'm not sure about adding these kernels; I don't know if
`in_list()` and `in_list_utf8()` are commonly used (they don't seem to be used
in DataFusion for example) and they do seem a bit oddly implemented (in that
the base version accepts only primitive, and the string version accepts only
Utf8/LargeUtf8 and not Utf8View) 🤔
Perhaps we can hold off on implementing these unless there's a motivating
usecase for them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
