jhorstmann commented on code in PR #9365:
URL: https://github.com/apache/arrow-rs/pull/9365#discussion_r2771512572
##########
parquet/src/encodings/rle.rs:
##########
@@ -465,7 +465,11 @@ impl RleDecoder {
if self.rle_left > 0 {
let num_values = cmp::min(max_values - values_read,
self.rle_left as usize);
let dict_idx = self.current_value.unwrap() as usize;
- let dict_value = dict[dict_idx].clone();
+
+ let dict_value = dict
Review Comment:
For large rle runs or small buffers it might be more efficient to check this
inside `reload`, but the difference in practice is probably minimal. Checking
it here is also consistent with the bitpacked runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
