jhorstmann commented on code in PR #9365:
URL: https://github.com/apache/arrow-rs/pull/9365#discussion_r2771548508
##########
parquet/src/file/metadata/mod.rs:
##########
@@ -1040,17 +1040,16 @@ impl ColumnChunkMetaData {
}
/// Returns the offset and length in bytes of the column chunk within the
file
- pub fn byte_range(&self) -> (u64, u64) {
+ pub fn byte_range(&self) -> Result<(u64, u64)> {
Review Comment:
Most other accessors for this struct return signed values and validation
seems to be left to the caller. I think it would be more consistent if
`byte_range` also returned a `(i64, i64)`. Even an `Ok` result here still needs
to be validated to be actually in bounds for the given file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
