AlenkaF commented on code in PR #48979:
URL: https://github.com/apache/arrow/pull/48979#discussion_r2791866577
##########
python/pyarrow/tests/parquet/test_basic.py:
##########
Review Comment:
Would it make sense to use integers for categories until fastparquet fully
supports pandas `3.0`? That way we can also check the dtype roundtrip here.
##########
python/pyarrow/tests/test_pandas.py:
##########
@@ -4956,7 +4956,7 @@ def test_timestamp_as_object_non_nanosecond(resolution,
tz, dt):
assert isinstance(result[0], datetime)
if tz:
assert result[0].tzinfo is not None
- expected = result[0].tzinfo.fromutc(dt)
+ expected =
dt.replace(tzinfo=timezone.utc).astimezone(result[0].tzinfo)
Review Comment:
This is totally legit, but we might want to use `tz` just to make it cleaner:
```suggestion
expected =
dt.replace(tzinfo=timezone.utc).astimezone(ZoneInfo(tz))
```
and we would need `from zoneinfo import ZoneInfo` on top of the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
