tadeja commented on code in PR #48979: URL: https://github.com/apache/arrow/pull/48979#discussion_r2794047286
########## python/pyarrow/tests/parquet/test_basic.py: ########## Review Comment: Ok, @AlenkaF here's the new approach with [ "f": pd.Categorical([5, 6, 7]),](https://github.com/apache/arrow/pull/48979/changes/8e90276f94148e599a904465535fb8bff3149516..7bd8eb39a09e5f48b753f4085bda761b8432b916#diff-daf07f9d0d68988737c70f2318af3751c2be271bb5d3ad0bcebbb1aa2f9349eaL742-R742) This fails the test at ``` tm.assert_frame_equal(table_fp.to_pandas(), df_for_fp, check_dtype=False) pyarrow/tests/parquet/test_basic.py:769: ... ... E AssertionError: Categorical Expected type <class 'pandas.Categorical'>, found <class 'numpy.ndarray'> instead ``` so we have to add another [check_categorical=False on line 769](https://github.com/apache/arrow/pull/48979/changes/8e90276f94148e599a904465535fb8bff3149516..7bd8eb39a09e5f48b753f4085bda761b8432b916#diff-daf07f9d0d68988737c70f2318af3751c2be271bb5d3ad0bcebbb1aa2f9349eaR770) as already done before at [line 756 for the same reason.](https://github.com/apache/arrow/pull/48979/changes/8e90276f94148e599a904465535fb8bff3149516..7bd8eb39a09e5f48b753f4085bda761b8432b916#diff-daf07f9d0d68988737c70f2318af3751c2be271bb5d3ad0bcebbb1aa2f9349eaL756) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
