GeorgeLeePatterson commented on code in PR #379:
URL: https://github.com/apache/arrow-js/pull/379#discussion_r2792656814
##########
src/util/interval.ts:
##########
@@ -46,7 +46,11 @@ export function toIntervalMonthDayNanoInt32Array(objects:
Partial<IntervalMonthD
data[ai++] = interval['days'] ?? 0;
const nanoseconds = interval['nanoseconds'];
if (nanoseconds) {
- const ns = BigInt(nanoseconds);
+ // Avoid BigInt(number) for unsafe integers, which can embed
+ // IEEE-754 rounding before conversion.
Review Comment:
Agreed. I'll update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
