GeorgeLeePatterson commented on code in PR #379:
URL: https://github.com/apache/arrow-js/pull/379#discussion_r2792660568
##########
test/unit/vector/interval-month-day-nano-tests.ts:
##########
@@ -77,4 +78,42 @@ describe(`MonthDayNanoIntervalVector`, () => {
expect(vec.get(0)).toStrictEqual(array);
expect(toIntervalMonthDayNanoObjects(vec.get(0),
false)).toStrictEqual([{ ...EMPTY_INTERVAL_MONTH_DAY_NANO_OBJECT, ...obj }]);
});
+
+ test(`Unsafe integer nanoseconds represented as bigint roundtrip
correctly`, () => {
+ const samples = [
+ '-390122861233460600',
+ '6684525287992311000'
+ ];
+ for (const sample of samples) {
+ const nanoseconds = BigInt(sample);
+ const obj: Partial<IntervalMonthDayNanoObject> = { nanoseconds };
Review Comment:
Has the same effect when the key name and variable name are the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
