alamb commented on PR #9367: URL: https://github.com/apache/arrow-rs/pull/9367#issuecomment-3886194783
## API commentary > Yes, this is what I was thinking. If we did this, then users could simply use set_compression, and then codec specific options don't creep into the options. I personally think that's worth a breaking change (and the window is currently open for those). I'm not sure how big the ripple effect is, though, if we change the enum. I think one thing that is important in several downstream projects that I know of (selfishly DataFusion and tpchgen-rs) is the ability to parse a string --> ZstdLevel So I would say as long as there is some good way to parse that (and that whatever currently works continues to do so ) it would be fine ## Request for empirical results Before we make a breaking API change like this, I would also like to see some empirical evidence that this setting makes a difference Perhaps we can create a test that shows when it enabled, large strings compress better? At least we should be able to make demonstration driver program (even if it is nota. test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
