alamb commented on code in PR #9367:
URL: https://github.com/apache/arrow-rs/pull/9367#discussion_r2794834670
##########
parquet/src/compression.rs:
##########
@@ -917,6 +942,25 @@ mod tests {
}
}
+ #[test]
+ fn test_codec_zstd_with_window_log() {
+ let level = ZstdLevel::try_new(3).unwrap();
+ let options = CodecOptionsBuilder::default()
+ .set_zstd_window_log_override(Some(27))
+ .build();
+ let mut codec = create_codec(CodecType::ZSTD(level), &options)
+ .unwrap()
+ .unwrap();
+ let data = b"hello world hello world hello world";
+ let mut compressed = Vec::new();
+ codec.compress(data, &mut compressed).unwrap();
+ let mut decompressed = Vec::new();
+ codec
+ .decompress(&compressed, &mut decompressed, Some(data.len()))
Review Comment:
This test will pass on main I think without your changes (assuming the API
was added)
In other words, if we accidentally disconnected the options or didn't pass
it through this test would still pass and thus it doesn't prevent regressions
Maybe we can add a test that uses two different window log overrides and
shows that the larger override results in smaller files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
