Jefffrey commented on code in PR #9373:
URL: https://github.com/apache/arrow-rs/pull/9373#discussion_r2802584788
##########
arrow-select/tests/test_257_u8.rs:
##########
@@ -0,0 +1,21 @@
+use arrow_array::{DictionaryArray, Int32Array, UInt8Array};
+use arrow_array::types::UInt8Type;
+use arrow_select::concat::concat;
+use std::sync::Arc;
+
+fn build_dict(start: u32, count: u32) -> DictionaryArray<UInt8Type> {
+ let values: Vec<i32> = (start..start + count).map(|v| v as i32).collect();
+ let values_array = Int32Array::from(values);
+ let keys = UInt8Array::from_iter_values(0..count as u8);
+ DictionaryArray::try_new(keys, Arc::new(values_array)).unwrap()
+}
+
+#[test]
+fn test_257_values_u8_should_fail() {
Review Comment:
Why are these tests now being introduced in a separate file again?
##########
arrow-select/tests/test_main_bug_verification.rs:
##########
@@ -0,0 +1,40 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#[cfg(test)]
+mod test_main_branch_bug {
+ use arrow_array::types::UInt8Type;
+ use arrow_array::{Array, DictionaryArray, StringArray, UInt8Array};
+ use arrow_select::concat::concat;
+ use std::sync::Arc;
+
+ #[test]
+ fn test_u8_dictionary_256_values_on_main() {
+ // This test should FAIL on main branch (proving the bug exists)
Review Comment:
Having a comment like this makes no sense because it wouldn't make sense in
the context of being on the main branch if the PR is ever merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
