gyanranjanpanda commented on PR #9373: URL: https://github.com/apache/arrow-rs/pull/9373#issuecomment-3895271476
Thank you for the candid feedback I appreciate it. You’re right that the recent changes (especially the separate test files and the “should FAIL on main” comments) do not align well with the existing project conventions. That’s on me. I will: Move the tests back into the appropriate existing test modules instead of introducing separate files. Remove comments that reference behavior on main and instead write the tests purely in terms of expected behavior after the fix. Reduce verbosity and ensure the tests match the style and tone of the existing codebase. I understand your concern about review burden. I will go back through the PR carefully and make sure the changes are minimal, consistent with the surrounding code, and fully reviewed by me before requesting further feedback. Thank you for taking the time to review this I’ll push a cleaned-up revision shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
