scovich commented on code in PR #9430:
URL: https://github.com/apache/arrow-rs/pull/9430#discussion_r2831246759
##########
arrow-array/src/builder/struct_builder.rs:
##########
@@ -213,6 +213,12 @@ impl StructBuilder {
self.null_buffer_builder.append(is_valid);
}
+ /// Appends `n` non-null entries into the builder.
+ #[inline]
+ pub fn append_non_nulls(&mut self, n: usize) {
+ self.null_buffer_builder.append_n_non_nulls(n);
Review Comment:
`append_nulls` below currently appends an n-element vec of `false` instead
of calling its `append_n_nulls`. It seems like both these methods should follow
the same approach -- whichever way is faster?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
