Fokko commented on code in PR #9430:
URL: https://github.com/apache/arrow-rs/pull/9430#discussion_r2832110069
##########
arrow-array/src/builder/struct_builder.rs:
##########
@@ -213,6 +213,12 @@ impl StructBuilder {
self.null_buffer_builder.append(is_valid);
}
+ /// Appends `n` non-null entries into the builder.
+ #[inline]
+ pub fn append_non_nulls(&mut self, n: usize) {
+ self.null_buffer_builder.append_n_non_nulls(n);
Review Comment:
Hey @scovich The n-element vec has been removed here:
https://github.com/apache/arrow-rs/pull/9428 I thought splitting it up into
smaller PRs would make the discussion easier. Allocating the vec is, as
expected, way slower. The null_buffer is implemented using a Bitmap in the form
of a `MutableBuffer`, which is way faster than the `vec`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
