brunal commented on code in PR #9447:
URL: https://github.com/apache/arrow-rs/pull/9447#discussion_r2833365658
##########
parquet/src/column/writer/mod.rs:
##########
@@ -409,8 +413,8 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a, E> {
codec,
compressor,
encoder,
- def_levels_sink: vec![],
- rep_levels_sink: vec![],
+ def_levels_encoder,
Review Comment:
nit: if you move those before descr/props lines 405/406, you can directly
`def_levels_encoder: Self::create_level_encoder(...)` without introducing 2
symbols
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
