brunal commented on code in PR #9447:
URL: https://github.com/apache/arrow-rs/pull/9447#discussion_r2833774785
##########
parquet/src/column/writer/mod.rs:
##########
@@ -409,8 +413,8 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a, E> {
codec,
compressor,
encoder,
- def_levels_sink: vec![],
- rep_levels_sink: vec![],
+ def_levels_encoder,
Review Comment:
Evaluated in the order of your local usage, not in their internal
declaration order, so you can move `def_levels_encoder` values before `descr` &
`props`:
```
Self {
def_levels_encoder:
Self::create_level_encoder(descr.max_def_level(), &props),
rep_levels_encoder:
Self::create_level_encoder(descr.max_rep_level(), &props),
descr,
props,
statistics_enabled,
// ...
}
```
compiles fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
