tustvold commented on code in PR #610:
URL:
https://github.com/apache/arrow-rs-object-store/pull/610#discussion_r2836047428
##########
src/lib.rs:
##########
@@ -1877,6 +1927,88 @@ pub struct PutResult {
pub version: Option<String>,
}
+/// Options for a delete request
+#[derive(Debug, Clone, Default)]
+pub struct DeleteOptions {
+ /// Delete will succeed if the `ObjectMeta::e_tag` matches
+ /// otherwise returning [`Error::Precondition`]
+ ///
+ /// See <https://datatracker.ietf.org/doc/html/rfc9110#name-if-match>
+ ///
+ /// Examples:
+ ///
+ /// ```text
+ /// If-Match: "xyzzy"
+ /// If-Match: "xyzzy", "r2d2xxxx", "c3piozzzz"
+ /// If-Match: *
+ /// ```
+ pub if_match: Option<String>,
Review Comment:
I think this will need to use something similar to UpdateVersion found in
PutMode as some stores don't support If-Match on mutating methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
