tustvold commented on code in PR #610:
URL:
https://github.com/apache/arrow-rs-object-store/pull/610#discussion_r2836047984
##########
src/gcp/client.rs:
##########
@@ -560,8 +560,17 @@ impl GoogleCloudStorageClient {
}
/// Perform a delete request
<https://cloud.google.com/storage/docs/xml-api/delete-object>
- pub(crate) async fn delete_request(&self, path: &Path) -> Result<()> {
- self.request(Method::DELETE, path).send().await?;
+ pub(crate) async fn delete_request(&self, path: &Path, opts:
DeleteOptions) -> Result<()> {
+ let mut builder = self
+ .request(Method::DELETE, path)
+ .with_extensions(opts.extensions)
+ .idempotent(true);
+
+ if let Some(if_match) = &opts.if_match {
+ builder = builder.header(&HeaderName::from_static("if-match"),
if_match);
Review Comment:
Have you tested this?
The docs would suggest If-Match is only supported on GET and HEAD
https://docs.cloud.google.com/storage/docs/xml-api/reference-headers#ifmatch
This is why PutMode has UpdateVersion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
