lidavidm commented on code in PR #49383:
URL: https://github.com/apache/arrow/pull/49383#discussion_r2852617690
##########
cpp/src/arrow/flight/server_tracing_middleware.cc:
##########
@@ -136,7 +136,7 @@ class TracingServerMiddlewareFactory : public
ServerMiddlewareFactory {
options.kind = otel::trace::SpanKind::kServer;
options.parent = otel::trace::GetSpan(new_otel_context)->GetContext();
- auto tracer =
otel::trace::Provider::GetTracerProvider()->GetTracer("arrow");
+ auto tracer = arrow::internal::tracing::GetTracer();
Review Comment:
Hmm, it's been a while since I've worked with OTel...possibly the OTel trace
provider isn't being configured (vs the hardcoded Arrow one)? The Arrow util is
about equivalent, but does some static initialization first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
