raulcd commented on code in PR #49383:
URL: https://github.com/apache/arrow/pull/49383#discussion_r2854787186
##########
cpp/src/arrow/util/tracing_internal.h:
##########
@@ -123,13 +125,13 @@ struct Scope {
opentelemetry::trace::Scope scope_impl;
};
-opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>& UnwrapSpan(
+ARROW_EXPORT opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span>&
UnwrapSpan(
Review Comment:
These symbols seem to be required to be exported for Windows:
```
2026-02-25T17:46:03.6802906Z
2026-02-25T17:46:03.6803059Z Finished searching libraries
2026-02-25T17:46:03.6813183Z unity_3_cxx.obj : error LNK2001: unresolved
external symbol "class opentelemetry::v1::nostd::shared_ptr<class
opentelemetry::v1::trace::Span> & __cdecl
arrow::internal::tracing::RewrapSpan(class arrow::util::tracing::SpanDetails
*,class opentelemetry::v1::nostd::shared_ptr<class
opentelemetry::v1::trace::Span>)"
(?RewrapSpan@tracing@internal@arrow@@YAAEAV?$shared_ptr@VSpan@trace@v1@opentelemetry@@@nostd@v1@opentelemetry@@PEAVSpanDetails@1util@3@V4567@@Z)
[C:\arrow-build\src\arrow\acero\arrow_acero_shared.vcxproj]
2026-02-25T17:46:03.6817761Z unity_2_cxx.obj : error LNK2001: unresolved
external symbol "class opentelemetry::v1::nostd::shared_ptr<class
opentelemetry::v1::trace::Span> & __cdecl
arrow::internal::tracing::UnwrapSpan(class arrow::util::tracing::SpanDetails
*)"
(?UnwrapSpan@tracing@internal@arrow@@YAAEAV?$shared_ptr@VSpan@trace@v1@opentelemetry@@@nostd@v1@opentelemetry@@PEAVSpanDetails@1util@3@@Z)
[C:\arrow-build\src\arrow\acero\arrow_acero_shared.vcxproj]
2026-02-25T17:46:03.6820710Z C:\arrow-build\release\Release\arrow_acero.dll
: fatal error LNK1120: 2 unresolved externals
[C:\arrow-build\src\arrow\acero\arrow_acero_shared.vcxproj]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
