kou commented on code in PR #49443:
URL: https://github.com/apache/arrow/pull/49443#discussion_r2887277857
##########
cpp/src/arrow/compute/kernels/scalar_if_else_test.cc:
##########
@@ -608,6 +608,28 @@ TYPED_TEST(TestIfElseBaseBinary, IfElseBaseBinaryRand) {
CheckIfElseOutput(cond, left, right, expected_data);
}
+TYPED_TEST(TestIfElseBaseBinary, IfElseBaseBinarySliced) {
+ auto type = TypeTraits<TypeParam>::type_singleton();
+
+ auto full_arr = ArrayFromJSON(type, R"([null, "x", "x", null, "x", "x"])");
+ auto sliced = full_arr->Slice(3);
Review Comment:
Can we simplify test data?
```suggestion
auto full_arr = ArrayFromJSON(type, R"(["not used", null, "x", "x"])");
auto sliced = full_arr->Slice(1);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
