Ebraam-Ashraf commented on PR #49443: URL: https://github.com/apache/arrow/pull/49443#issuecomment-4023097748
@kou regarding copilot's feedback applied it this is more correct since the data copy already keys on offsets[0] so the branch condition should match I initially thought offset == 0 with offsets[0] != 0 was impossible but after checking the spec and ValidateFull() both allow it so it's possible to craft such an array manually do you think a test is needed for this edge case or is the existing sufficient? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
