Tim-53 commented on PR #9508: URL: https://github.com/apache/arrow-rs/pull/9508#issuecomment-4015346958
Just updated the PR to remove the `debug_assert_eq! `instead of weakening it to `>=`. The assertion was originally added in #9132 as part of an anti-over-allocation optimization. Changing to `>=` silently lose that invariant. But i agree removing the assertion here is the right call. I'm not sure what a meaningful replacement test would look like here, since the assertion was guarding internal memory behavior rather than observable output. Happy to add a test if someone has a good idea what to check here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
