Tim-53 commented on PR #9508: URL: https://github.com/apache/arrow-rs/pull/9508#issuecomment-4024429455
> > This should be a change to the `debug_assert` to be `>=` rather than here I think? Reserving exact will increase memory fragmentation > > Btw - I didn't really understand this part? In this code using `reserve_exact` shouldn't lead to memory fragmentation? Note that we always target max `self.batch_size` in this code (it will never exceed this). I think when I wrote this, I was thinking of cases where the allocation size could change over time and trigger multiple reallocations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
