kentkwu commented on code in PR #4076:
URL: https://github.com/apache/arrow-adbc/pull/4076#discussion_r2925613048


##########
.github/workflows/packaging.yml:
##########
@@ -1219,13 +1224,44 @@ jobs:
           done
 
       - name: Upload Node.js packages
-        uses: actions/upload-artifact@v5
+        uses: actions/upload-artifact@v7
         with:
           name: node-packages
           retention-days: 7
           path: |
             adbc/javascript/*.tgz
 
+  upload-npm:
+    name: "Upload Node.js packages to npm"
+    runs-on: ubuntu-latest
+    if: github.ref == 'refs/heads/main' && (github.event.schedule || 
inputs.upload_npm)

Review Comment:
   Yeah good catch. Got a bit confused by the naming. Updated.
   
   Should we consider renaming to `upload-nightly` or something similar? Happy 
to handle in a separate PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to