kou commented on code in PR #4076:
URL: https://github.com/apache/arrow-adbc/pull/4076#discussion_r2928479263
##########
.github/workflows/packaging.yml:
##########
@@ -1226,6 +1231,37 @@ jobs:
path: |
adbc/javascript/*.tgz
+ upload-npm:
+ name: "Upload Node.js packages to npm"
+ runs-on: ubuntu-latest
+ if: github.ref == 'refs/heads/main' && (github.event.schedule ||
inputs.upload_npm)
+ needs:
+ - node-dist
+ environment: npm
+ steps:
+ - uses: actions/checkout@v6
+ with:
+ fetch-depth: 0
+ persist-credentials: false
+
+ - name: Download Node.js packages
+ uses: actions/download-artifact@v8
+ with:
+ name: node-packages
+ path: packages
+
+ - name: Setup Node
+ uses: actions/setup-node@v4
+ with:
+ node-version: 24
+ registry-url: 'https://registry.npmjs.org'
+
+ - name: Publish to npm
+ env:
+ NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Review Comment:
Oh, sorry. I missed it.
> For Node.js I would like for users to have a nightly available. Let me
know if there are objections to this.
We should not provide nightly packages to "users". We can provide them only
for "developers".
https://www.apache.org/legal/release-policy.html#publication
> Projects SHALL publish official releases and SHALL NOT publish unreleased
materials outside the development community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
