crepererum commented on code in PR #669:
URL:
https://github.com/apache/arrow-rs-object-store/pull/669#discussion_r2959290480
##########
src/aws/builder.rs:
##########
@@ -679,7 +679,13 @@ impl AmazonS3Builder {
self.conditional_put = ConfigValue::Deferred(value.into())
}
AmazonS3ConfigKey::RequestPayer => {
- self.request_payer = ConfigValue::Deferred(value.into())
+ // Support the standard AWS value "requester" as a boolean true
Review Comment:
the parsing logic should be part of the value type, like this:
https://github.com/apache/arrow-rs-object-store/blob/bdcac43fc637ac89cc80f18f4e16b3fb66fd0ec8/src/aws/builder.rs#L1330-L1365
Now from the user PoV this doesn't make a difference, but using this pattern
makes the code easier to read and maintain (no surprising "why is this value
handled differently and where is the code that does this out of the sudden?"
surprises)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
