kylebarron commented on code in PR #669:
URL:
https://github.com/apache/arrow-rs-object-store/pull/669#discussion_r2960240131
##########
src/aws/builder.rs:
##########
@@ -679,7 +679,13 @@ impl AmazonS3Builder {
self.conditional_put = ConfigValue::Deferred(value.into())
}
AmazonS3ConfigKey::RequestPayer => {
- self.request_payer = ConfigValue::Deferred(value.into())
+ // Support the standard AWS value "requester" as a boolean true
Review Comment:
@crepererum Putting this as part of the `impl Parse for bool`
https://github.com/apache/arrow-rs-object-store/blob/bdcac43fc637ac89cc80f18f4e16b3fb66fd0ec8/src/config.rs#L74-L86
means that _any_ boolean flag is enabled by the string `"requester"`, right?
From my point of view if we allow this case, it seems perhaps better to
isolate it to the `AWS_REQUEST_PAYER` code path? 🤷♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
