etseidl commented on code in PR #9447:
URL: https://github.com/apache/arrow-rs/pull/9447#discussion_r2961190405
##########
parquet/src/column/writer/mod.rs:
##########
@@ -1155,10 +1168,6 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a,
E> {
// Update total number of rows.
self.column_metrics.total_rows_written +=
self.page_metrics.num_buffered_rows as u64;
-
- // Reset state.
Review Comment:
```suggestion
// Reset state.
```
##########
parquet/src/encodings/levels.rs:
##########
@@ -26,6 +26,7 @@ use crate::util::bit_util::{BitWriter, ceil,
num_required_bits};
/// Computes max buffer size for level encoder/decoder based on encoding, max
/// repetition/definition level and number of total buffered values (includes
null
/// values).
+#[allow(dead_code)]
Review Comment:
should the dead code be deprecated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
