kou commented on code in PR #49564:
URL: https://github.com/apache/arrow/pull/49564#discussion_r2978425996
##########
.github/workflows/cpp_extra.yml:
##########
@@ -336,6 +336,64 @@ jobs:
cd cpp/examples/minimal_build
../minimal_build.build/arrow-example
+ odbc-linux:
+ needs: check-labels
+ name: ODBC Linux
+ runs-on: ubuntu-latest
+ if: >-
+ needs.check-labels.outputs.force == 'true' ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra') ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra: C++')
+ timeout-minutes: 75
+ strategy:
+ fail-fast: false
+ env:
+ ARCH: amd64
+ ARCHERY_DEBUG: 1
+ ARROW_ENABLE_TIMING_TESTS: OFF
+ CLANG_TOOLS: 18
+ DOCKER_VOLUME_PREFIX: ".docker/"
+ LLVM: 18
Review Comment:
Do we need this? We don't enable Gandiva, right?
##########
.github/workflows/cpp_extra.yml:
##########
@@ -336,6 +336,64 @@ jobs:
cd cpp/examples/minimal_build
../minimal_build.build/arrow-example
+ odbc-linux:
+ needs: check-labels
+ name: ODBC Linux
+ runs-on: ubuntu-latest
+ if: >-
+ needs.check-labels.outputs.force == 'true' ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra') ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra: C++')
+ timeout-minutes: 75
+ strategy:
+ fail-fast: false
+ env:
+ ARCH: amd64
+ ARCHERY_DEBUG: 1
+ ARROW_ENABLE_TIMING_TESTS: OFF
+ CLANG_TOOLS: 18
Review Comment:
Do we need this?
##########
cpp/src/arrow/flight/sql/odbc/install/unix/install_odbc.sh:
##########
Review Comment:
Could you also update `.pre-commit-config.yaml`?
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/encoding_utils.h:
##########
@@ -28,8 +28,26 @@
#include <memory>
#include <string>
+// Workaround for ODBC `BOOL` def conflict on Linux
+#ifdef __linux__
+# ifdef BOOL
+# undef BOOL
+# endif // BOOL
+#endif // __linux__
Review Comment:
We have this workaround in multiple places. Can we unify them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
