alinaliBQ commented on code in PR #49564:
URL: https://github.com/apache/arrow/pull/49564#discussion_r2984815041
##########
.github/workflows/cpp_extra.yml:
##########
@@ -336,6 +336,64 @@ jobs:
cd cpp/examples/minimal_build
../minimal_build.build/arrow-example
+ odbc-linux:
+ needs: check-labels
+ name: ODBC Linux
+ runs-on: ubuntu-latest
+ if: >-
+ needs.check-labels.outputs.force == 'true' ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra') ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra: C++')
+ timeout-minutes: 75
+ strategy:
+ fail-fast: false
+ env:
+ ARCH: amd64
+ ARCHERY_DEBUG: 1
+ ARROW_ENABLE_TIMING_TESTS: OFF
+ CLANG_TOOLS: 18
+ DOCKER_VOLUME_PREFIX: ".docker/"
+ LLVM: 18
Review Comment:
Yea this env var isn't needed, removed.
##########
cpp/src/arrow/flight/sql/odbc/install/unix/install_odbc.sh:
##########
Review Comment:
yes good catch, updated
##########
.github/workflows/cpp_extra.yml:
##########
@@ -336,6 +336,64 @@ jobs:
cd cpp/examples/minimal_build
Review Comment:
TEMP
##########
.github/workflows/cpp_extra.yml:
##########
@@ -336,6 +336,64 @@ jobs:
cd cpp/examples/minimal_build
../minimal_build.build/arrow-example
+ odbc-linux:
+ needs: check-labels
+ name: ODBC Linux
+ runs-on: ubuntu-latest
+ if: >-
+ needs.check-labels.outputs.force == 'true' ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra') ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra: C++')
+ timeout-minutes: 75
+ strategy:
+ fail-fast: false
+ env:
+ ARCH: amd64
+ ARCHERY_DEBUG: 1
+ ARROW_ENABLE_TIMING_TESTS: OFF
+ CLANG_TOOLS: 18
Review Comment:
This can be removed, fixed. Good catch
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/encoding_utils.h:
##########
@@ -28,8 +28,26 @@
#include <memory>
#include <string>
+// Workaround for ODBC `BOOL` def conflict on Linux
+#ifdef __linux__
+# ifdef BOOL
+# undef BOOL
+# endif // BOOL
+#endif // __linux__
Review Comment:
Yes, done
##########
.github/workflows/cpp_extra.yml:
##########
@@ -336,6 +336,64 @@ jobs:
cd cpp/examples/minimal_build
Review Comment:
TEMP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
