wgtmac commented on code in PR #49490:
URL: https://github.com/apache/arrow/pull/49490#discussion_r2978547476
##########
cpp/src/parquet/column_writer_test.cc:
##########
@@ -1053,8 +1053,10 @@ TEST(TestColumnWriter,
LARGE_MEMORY_TEST(WriteLargeDictEncodedPage)) {
{
PrimitiveNode::Make("item", Repetition::REQUIRED,
Type::INT32),
}));
- auto properties =
- WriterProperties::Builder().data_pagesize(1024 * 1024 * 1024)->build();
+ auto properties = WriterProperties::Builder()
+ .data_pagesize(1024 * 1024 * 1024)
+
->max_rows_per_page(std::numeric_limits<int64_t>::max())
Review Comment:
Does it mean that we want to respect `data_pagesize` only? If yes, this fix
looks good. I think this test was broken after I have added `max_rows_per_page`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
