raulcd commented on code in PR #49490:
URL: https://github.com/apache/arrow/pull/49490#discussion_r2979872003
##########
cpp/src/parquet/column_writer_test.cc:
##########
@@ -1053,8 +1053,10 @@ TEST(TestColumnWriter,
LARGE_MEMORY_TEST(WriteLargeDictEncodedPage)) {
{
PrimitiveNode::Make("item", Repetition::REQUIRED,
Type::INT32),
}));
- auto properties =
- WriterProperties::Builder().data_pagesize(1024 * 1024 * 1024)->build();
+ auto properties = WriterProperties::Builder()
+ .data_pagesize(1024 * 1024 * 1024)
+
->max_rows_per_page(std::numeric_limits<int64_t>::max())
Review Comment:
> Does it mean that we want to respect data_pagesize only?
From what I understand, yes those large memory tests where designed to test
huge pages and `max_rows_per_page` was just creating smaller than expected
pages for the test.
> I think this test was broken after I have added max_rows_per_page.
Also yes, those tests were broken after we added `max_rows_per_page`. We
realize now because I am adding a CI job that will exercise those, this is an
example of why adding this to CI can help find those :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
