raulcd commented on code in PR #49377: URL: https://github.com/apache/arrow/pull/49377#discussion_r2986813768
########## python/pyarrow/_parquet.pyx: ########## @@ -51,6 +51,10 @@ cimport cpython as cp _DEFAULT_ROW_GROUP_SIZE = 1024*1024 _MAX_ROW_GROUP_SIZE = 64*1024*1024 +# from definition of BloomFilterOptions struct +_DEFAULT_BLOOM_FILTER_NDV = 1024*1024 +_DEFAULT_BLOOM_FILTER_FPP = 0.05 Review Comment: Are those necessary to be defined? Aren't those just picked as default from the C++ struct initialization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
