pitrou commented on code in PR #49377:
URL: https://github.com/apache/arrow/pull/49377#discussion_r2986893648
##########
python/pyarrow/_parquet.pyx:
##########
@@ -2122,6 +2128,49 @@ cdef shared_ptr[WriterProperties]
_create_writer_properties(
raise TypeError(
"'column_encoding' should be a dictionary or a string")
+ # bloom filters
+ if bloom_filter_options is not None:
+ if isinstance(bloom_filter_options, dict):
Review Comment:
Can we factor this out into a helper function? This function is becoming
much too large IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
