westonpace commented on a change in pull request #10205: URL: https://github.com/apache/arrow/pull/10205#discussion_r626237982
########## File path: cpp/src/arrow/util/future.h ########## @@ -691,20 +862,29 @@ struct Continue { } }; -template <typename T = detail::Empty> +template <typename T = internal::Empty> util::optional<T> Break(T break_value = {}) { return util::optional<T>{std::move(break_value)}; } -template <typename T = detail::Empty> +template <typename T = internal::Empty> using ControlFlow = util::optional<T>; +template <typename T> +void ForwardControlResult(const Result<ControlFlow<T>>& result, Future<T>& sink) { Review comment: At this point we're done with `break_fut` so I changed it to move `break_fut` and got rid of the `&`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org