bkietz commented on a change in pull request #10205: URL: https://github.com/apache/arrow/pull/10205#discussion_r626751707
########## File path: cpp/src/arrow/util/thread_pool.h ########## @@ -227,14 +228,14 @@ class ARROW_EXPORT SerialExecutor : public Executor { std::shared_ptr<State> state_; template <typename T> - Result<T> Run(TopLevelTask<T> initial_task) { + Future<T> Run(TopLevelTask<T> initial_task) { auto final_fut = std::move(initial_task)(this); if (final_fut.is_finished()) { - return final_fut.result(); + return final_fut; } - final_fut.AddCallback([this](const Result<T>&) { MarkFinished(); }); + final_fut.AddCallback([this](...) { MarkFinished(); }); Review comment: `...` is not a template, and in particular is distinct from a parameter pack. Ellipsis indicates a [variadic function](https://en.cppreference.com/w/cpp/language/variadic_arguments) (whose arguments must be accessed with `va_start` and friends) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org