AdamGS commented on code in PR #9610:
URL: https://github.com/apache/arrow-rs/pull/9610#discussion_r3003405584
##########
parquet-variant-compute/src/variant_array.rs:
##########
@@ -957,9 +985,8 @@ fn typed_value_to_variant<'a>(
let value = array.value(index);
Ok(Uuid::from_slice(value).unwrap().into()) // unwrap is safe:
slice is always 16 bytes
}
- DataType::BinaryView => {
- let array = typed_value.as_binary_view();
- let value = array.value(index);
+ DataType::Binary | DataType::LargeBinary | DataType::BinaryView => {
+ let value = binary_array_value(typed_value.as_ref(), index);
Review Comment:
can fit `value` and `metadata` right? was looking for something like it, but
I didn't know about `ListLikeArray`, I'll look into it. One annoying difference
here is that the spec doesn't seem to accept fixed sized binary, which might be
weird but prevents us from fully assuming its a binary datatype.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
