AdamGS commented on code in PR #9610:
URL: https://github.com/apache/arrow-rs/pull/9610#discussion_r3072137860
##########
parquet-variant-compute/src/variant_get.rs:
##########
@@ -268,9 +268,25 @@ fn try_perfect_shredding(variant_array: &VariantArray,
as_field: &Field) -> Opti
// 2. If every row in the `value` column is null
// This is a perfect shredding, where the value is entirely shredded
out,
- // so we can just return the typed value.
- return Some(typed_value.clone());
+ // so we can just return the typed value after merging the accumulated
nulls.
Review Comment:
I'll double check if its was a pre-existing bug or just something I
introduced, if it already exists I'll split it out into a separate PR, hoping
to get around to it later this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
