viirya commented on code in PR #9628:
URL: https://github.com/apache/arrow-rs/pull/9628#discussion_r3012775120
##########
parquet/src/arrow/arrow_writer/byte_array.rs:
##########
@@ -443,10 +450,30 @@ impl ColumnValueEncoder for ByteArrayEncoder {
let fallback = FallbackEncoder::new(descr, props)?;
- let bloom_filter = props
- .bloom_filter_properties(descr.path())
- .map(|props| Sbbf::new_with_ndv_fpp(props.ndv, props.fpp))
- .transpose()?;
+ let (bloom_filter, bloom_filter_target_fpp) =
Review Comment:
Is the bloom filter creation logic the same as encoder.rs? Maybe we can
extract `fn create_bloom_filter`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
