alamb commented on code in PR #9605:
URL: https://github.com/apache/arrow-rs/pull/9605#discussion_r3024784220
##########
arrow-avro/src/reader/record.rs:
##########
@@ -5611,4 +5629,788 @@ mod tests {
other => panic!("expected Timestamp(Nanosecond, None), got
{other:?}"),
}
}
+
+ /// When a Skip field references a named type by name, the Skipper must
use the
+ /// writer's wire format for that type. Here the reader wraps the
Timestamp's scalar
+ /// fields in nullable unions, but the writer wrote them as plain values;
the Skipper
+ /// must not add a union-tag read for each field.
+ #[test]
Review Comment:
these tests seem pretty repetitive and thus it is hard for me to understand
what they are supposed to be testing and validate what is different between tehm
Can you please refactor the common functionality into helper functions so
the tests themselves are easier to understand and validate ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
