jecsand838 commented on PR #9605: URL: https://github.com/apache/arrow-rs/pull/9605#issuecomment-4173278884
> Thank you for this PR @ariel-miculas 🙏 > > I defer to @jecsand838 's opinion on code structure > > Before approving this PR I would would request that we: > > 1. Try and make the tests easier to understand (see comemnts below) > 2. File a ticket that explains what the end user of this crate would see before this code fix (I can't quite tell from the PR description which focuses on what the code does, not the end user visible behavior) > > It would also be nice to file a ticket to track @jecsand838 's suggestion for a different structure @alamb I created that tracking ticket: https://github.com/apache/arrow-rs/issues/9651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
