crepererum commented on code in PR #633:
URL:
https://github.com/apache/arrow-rs-object-store/pull/633#discussion_r3044086641
##########
src/aws/client.rs:
##########
@@ -708,30 +734,52 @@ impl S3Client {
}
let (parts, body) = request.send().await?.into_parts();
- let (e_tag, checksum_sha256) = if is_copy {
+ let (e_tag, checksum_sha256, checksum_crc64nvme) = if is_copy {
let response = body
.bytes()
.await
.map_err(|source| Error::CreateMultipartResponseBody { source
})?;
let response: CopyPartResult =
quick_xml::de::from_reader(response.reader())
.map_err(|source| Error::InvalidMultipartResponse { source })?;
- (response.e_tag, response.checksum_sha256)
+ (
+ response.e_tag,
+ response.checksum_sha256,
+ response.checksum_crc64nvme,
+ )
} else {
let e_tag = get_etag(&parts.headers).map_err(|source|
Error::Metadata { source })?;
let checksum_sha256 = parts
.headers
.get(SHA256_CHECKSUM)
.and_then(|v| v.to_str().ok())
.map(|v| v.to_string());
- (e_tag, checksum_sha256)
+ let checksum_crc64nvme = parts
+ .headers
+ .get(CRC64NVME_CHECKSUM)
+ .and_then(|v| v.to_str().ok())
+ .map(|v| v.to_string());
+ (e_tag, checksum_sha256, checksum_crc64nvme)
};
- let content_id = if self.config.checksum == Some(Checksum::SHA256) {
- let meta = PartMetadata {
- e_tag,
- checksum_sha256,
- };
- quick_xml::se::to_string(&meta).unwrap()
+ let content_id = if let Some(checksum) = self.config.checksum {
Review Comment:
I still don't understand why the match block below just doesn't copy both
checksums that you've extracted from the headers (you don't even have to
compute it). Why do we strip one of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
