kdn36 commented on PR #633:
URL: 
https://github.com/apache/arrow-rs-object-store/pull/633#issuecomment-4198770085

   > I'm still confused about the copy behavior, see 
https://github.com/apache/arrow-rs-object-store/pull/633/changes#r3044086641
   
   Updated after re-review.
   
   Note and fwiw, I oberved different behavior between AWS and Localstack, in 
that AWS will add a Checksum header for the Copy path, but Localstack will not.
   
   With
   ```
   $ cargo test --features aws copy_multipart_file_with_signature -- 
--no-capture
   ```
   
   AWS:
   ```
   $ cat debug_aws.out
   running 2 tests
   [src/aws/client.rs:714:9] "start put_part" = "start put_part"
   [src/aws/client.rs:769:9] &checksum_sha256 = Some(
       "kZLCW3NPy62+MtrcKAicYNsOOfkMwgzi5XM/VyYazAw=",
   )
   [src/aws/client.rs:770:9] &checksum_crc64nvme = None
   [src/aws/client.rs:714:9] "start put_part" = "start put_part"
   [src/aws/client.rs:769:9] &checksum_sha256 = None
   [src/aws/client.rs:770:9] &checksum_crc64nvme = Some(
       "m0nypWpUsto=",
   )
   test aws::tests::copy_multipart_file_with_signature_change_checksum ... ok
   [src/aws/client.rs:714:9] "start put_part" = "start put_part"
   [src/aws/client.rs:769:9] &checksum_sha256 = None
   [src/aws/client.rs:770:9] &checksum_crc64nvme = Some(
       "m0nypWpUsto=",
   )
   test aws::tests::copy_multipart_file_with_signature ... ok
   ```
   Localstack:
   ```
   $ cat debug_localstack.out
   running 2 tests
   [src/aws/client.rs:714:9] "start put_part" = "start put_part"
   [src/aws/client.rs:769:9] &checksum_sha256 = None
   [src/aws/client.rs:770:9] &checksum_crc64nvme = None
   [src/aws/client.rs:714:9] "start put_part" = "start put_part"
   [src/aws/client.rs:769:9] &checksum_sha256 = None
   [src/aws/client.rs:770:9] &checksum_crc64nvme = None
   test aws::tests::copy_multipart_file_with_signature_change_checksum ... ok
   [src/aws/client.rs:714:9] "start put_part" = "start put_part"
   [src/aws/client.rs:769:9] &checksum_sha256 = None
   [src/aws/client.rs:770:9] &checksum_crc64nvme = None
   test aws::tests::copy_multipart_file_with_signature ... ok
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to