AdamGS commented on code in PR #9610:
URL: https://github.com/apache/arrow-rs/pull/9610#discussion_r3074846272
##########
parquet-variant-compute/src/variant_array.rs:
##########
@@ -1172,10 +1208,8 @@ fn canonicalize_and_verify_data_type(data_type:
&DataType) -> Result<Cow<'_, Dat
Date32 | Time64(TimeUnit::Microsecond) => borrow!(),
Date64 | Time32(_) | Time64(_) | Duration(_) | Interval(_) => fail!(),
- // Binary and string are allowed. Force Binary/LargeBinary to
BinaryView because that's what the parquet
- // reader returns and what the rest of the variant code expects.
- Binary | LargeBinary => Cow::Owned(BinaryView),
- BinaryView | Utf8 | LargeUtf8 | Utf8View => borrow!(),
+ // Binary, string, and their view counterparts are allowed.
+ Binary | LargeBinary | BinaryView | Utf8 | LargeUtf8 | Utf8View =>
borrow!(),
Review Comment:
This is a key point here re #9702, we shouldn't force binary-like arrays
into any different code paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
