rok commented on PR #49718: URL: https://github.com/apache/arrow/pull/49718#issuecomment-4239746438
> I suppose `VariableShapeTensorType` must be similarily improved, right? `shape` is not stored in metadata of `VariableShapeTensorType` but rather in a field of the struct array (which is storage of variable shape tensor) and could be created invalid. But that wouldn't be checked at deserialization time typically. Is this a check we should do at deserialization time? We do have `uniform_shape` which we currently parse and partly validate, but don't really validate. The idea was to potentially use it for optimizations later on/ I added a validation step for `permutation`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
